Skip to content

Fallback to pcb_component rectangles when mesh boxes are missing#84

Open
helmutkocksmann wants to merge 2 commits into
tscircuit:mainfrom
helmutkocksmann:main
Open

Fallback to pcb_component rectangles when mesh boxes are missing#84
helmutkocksmann wants to merge 2 commits into
tscircuit:mainfrom
helmutkocksmann:main

Conversation

@helmutkocksmann

Copy link
Copy Markdown

Fixes #6.

/claim #6

Summary:

  • adds a direct pcb_component rectangle fallback when the GLTF converter returns no component boxes
  • uses the filtered circuit JSON for fallback generation so externally merged STEP models are not duplicated
  • adds focused coverage for top/bottom fallback box placement and skipped invalid dimensions

Verification:

  • git diff --check
  • not run: bun test (bun is not installed in this environment)

Create rectangular STEP boxes when component mesh generation returns no boxes.
Cover fallback rectangles for simple pcb_component data.
@vercel

vercel Bot commented May 11, 2026

Copy link
Copy Markdown

@helmutkocksmann is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine why rectangles are missing in output

1 participant